Add {ImageBuffer,DynamicImage}::crop_in_place #2701
Merged
+99
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `flipv_in_place` this never needs to grow the underlying container. Our behavior of clipping the crop selection to the images dimensions ensures that the target dimensions are always smaller.
197g
commented
Dec 20, 2025
|
|
||
| self.width = selection.width; | ||
| self.height = selection.height; | ||
| } |
Member
Author
There was a problem hiding this comment.
Note: we can't shrink the container here as this is generic over it. We could do it in DynamicImage on top of the original transform to avoid issues as rust-lang/rust#120091 even though additional conditions may be necessary for the behavior to be considered particular surprising (i.e. the linked issues is because an internal use of vec reserve/truncate leaves it with a lot of capacity, an analogy would thus be an operation that internally crops, but for instance ImageReader #2672 could truncate itself quite well).
Member
Author
There was a problem hiding this comment.
Let's at least introduce the necessary method for this in the same patch.
The underlying vector can be accessed and shrunk to its own length by itself so this also shrinks the length of the vector to fit the image.
fintelia
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
flipv_in_placethis never needs to grow the underlying container. Our behavior of clipping the crop selection to the images dimensions ensures that the target dimensions are always smaller.As discussed, besides the obvious performance advantages over other forms of cropping into a new allocation this would also be relevant to #2672 .
As a complementary method introduce
ImageBuffer::shrink_to_fit.