support more color type in Jpeg Encoder #2718
Open
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rayguo17 <rayguo17@gmail.com>
fintelia
reviewed
Jan 5, 2026
| let color = jpeg_encoder::ColorType::Rgb; | ||
| encode_jpeg(color) | ||
| } | ||
| ExtendedColorType::Rgba8 => { |
Contributor
There was a problem hiding this comment.
The JPEG encoder should not claim to support color types with alpha channels and then silently drop them.
See the note here: https://docs.rs/image/0.25.9/image/enum.DynamicImage.html#color-conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c898457, we change to encoder in
jpeg_encoderinstead of our own implementation, this PR add moreExtendedColorTypethat is supported injpeg_encodercrate, but is previously not supported by our own implementation.