Add f16 color formats to ExtendedColorType#3030
Open
RunDevelopment wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I split off
f16colors from #3015, because that PR might take a little.Motivation
fp16 is already a common and widespread format for representing colors. It can losslessly represent 11-bit UNORM and has the ability to represent number outside the range 0-1. This makes it a great format for HDR content. Image formats that natively support fp16 are TIFF and DDS.
While Rust itself has yet to stabilize
f16, there is value in adding these toExtendedColorTypeeven if we don't support de/encoding images with it right now. The main pro is that decoders can use these variants to accurately report the original color type. For example, DDS has theR16G16B16A16_FLOATcolor type.Description
I added
L16F,La16F,Rgb16F, andRgba16FtoExtendedColorType. They are placed last (but beforeUnknown(u8)) to not mess with serde.