fix(scripts/single.sh): remove invalid empty-db startup command and correct debug/error logging#382
Open
Giriprasada wants to merge 1 commit into
Open
fix(scripts/single.sh): remove invalid empty-db startup command and correct debug/error logging#382Giriprasada wants to merge 1 commit into
Giriprasada wants to merge 1 commit into
Conversation
…orrect debug/error output
- remove stray `--rebuild-gvmd-data=report_formats` line from CREATE_EMPTY_DATABASE path
- fix debug logging to print actual variable values with `${!var}`
- report actual PostgreSQL start failure code using `$PGFAIL`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
When
CREATE_EMPTY_DATABASE=true(orNEWDB=true),scripts/single.shfails during startup because the script contains a stray line:--rebuild-gvmd-data=report_formats
That line is not a shell command and aborts the script.
To Reproduce
NEWDB=trueorCREATE_EMPTY_DATABASE=true.docker-compose.ymlwith the env var set.Expected behavior
The container should finish empty DB creation and continue startup.
Environment
Additional context
scripts/single.shin theCREATE_EMPTY_DATABASEbranch.${var}instead of${!var}.$?incorrectly instead of$PGFAIL.Resolution
Remove or fix the stray command: