feat(heremap): allow choosing map engine via prop#19
Merged
KhaledSakr merged 2 commits intomasterfrom Feb 20, 2025
Merged
Conversation
Member
Author
|
/publish |
Collaborator
|
RUN URL: https://github.com/impargo/react-here-maps/actions/runs/13287687924 |
KhaledSakr
force-pushed
the
feature/pos-2126
branch
from
0d0f7f2 to
2239fcc
Compare
Member
Author
|
/publish |
Collaborator
|
RUN URL: https://github.com/impargo/react-here-maps/actions/runs/13290063314 |
KhaledSakr
force-pushed
the
feature/pos-2126
branch
from
2239fcc to
6ee99d0
Compare
Member
Author
|
/publish |
Collaborator
|
RUN URL: https://github.com/impargo/react-here-maps/actions/runs/13292372282 |
mowaleed96
reviewed
Feb 13, 2025
src/useRasterLayers.ts
Outdated
| defaultLayers?: DefaultLayers, | ||
| apiKey: string, | ||
| useVectorTiles: boolean, | ||
| enable: boolean, |
Member
Author
There was a problem hiding this comment.
Makes sense. I changed it to enableVectorLayers and enableRasterLayers
mowaleed96
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the PR Includes
Checklist
Manual Testing Instructions