fix(heremap): preserve integer zoom when focusing on markers#20
Merged
KhaledSakr merged 2 commits intomasterfrom Feb 12, 2025
Merged
fix(heremap): preserve integer zoom when focusing on markers#20KhaledSakr merged 2 commits intomasterfrom
KhaledSakr merged 2 commits intomasterfrom
Conversation
Member
Author
|
/publish |
Collaborator
|
RUN URL: https://github.com/impargo/react-here-maps/actions/runs/13290812359 |
Member
Author
|
/publish |
Collaborator
|
RUN URL: https://github.com/impargo/react-here-maps/actions/runs/13291197236 |
KhaledSakr
force-pushed
the
feature/pos-2137
branch
from
d00d635 to
f1f5bb1
Compare
Member
Author
|
/publish |
Collaborator
|
RUN URL: https://github.com/impargo/react-here-maps/actions/runs/13291372178 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the PR Includes
Because of how raster tiles work, the tiles are different based on the zoom level. For example: When zoom level is 12, a tile image covers a certain area, when zooming in to level 13 (meaning, the same land area occupies bigger screen space), a new image needs to be fetched to cover the smaller area.
If fractional zooming is allowed, then a level 12.4 or 12.5 zoom is possible. In this case, the level 12 tiles are still used, but they are stretched over bigger screen space, leading to blurriness.
This change ensures that zoom levels are always integers by passing
opt_integerZoom=truetosetLookAtDatawhen zooming on a marker or a group of markers.