fix anomalocarids getting cut off in the character menu + offsets fixes #3859
Conversation
github-actions
bot
added
S: Untriaged
size/S
S: Needs Review
Changes: No C#
Changes: UI
Changes: Upstream
and removed
S: Needs Review
size/S
labels
|
also if there are any xaml knowers PLEASE help me with this i have no idea what anything does and i'm just winging it |
…ng terribly wrong here but it works fine and looks good.
i fixed it but my method of fixing it surely is not correct. it looks perfect and even fixes another bug the character creation screen has (antag menu resizing the dummy) but... i did this in a bad way. |
|
marking as ready to review so a xaml knower can yell at me |
i think some bad things have happened here
|
|
aw man... i thought i tested it with everyone!! i'm really not sure how to get the effect i want from this i do NOT know xml at all... i desperately need help |
|
|
i do worry about this way of doing it still, this is a screenshot taken in a windowed mode... idk this xaml shit is fucking exhausting and I GUESS this technically works. but since anomalocarids arent roundstart this isnt user-facing for them, so i think we can afford to give this pr a little time to cook in case some magic genie finds a miracle solution (AFFIRMATION)
|
|
That... didn't happen for me. I checked windowed mode and it was fine, I even resized it a bunch... |
|
i think the actual solution to this is finding a way to make the human profile editor start out by resetting the size the way it does when you tab over to the antag menu. because they look fine if you just do that. the problem is that the ONLY reason i could find for why the antag tab does that is because it has text at the top of it |
|
yeah, and that text on antag tab is an imp addition. bear im willing to bet our different outcomes were probably due to different screen resolutions, im using a shitty little laptop. what probably needs to happen to get the desired outcome is some .xaml.cs bullshit.... ive fucked with it a bit and COULD take a look but i am conscious of this growing review backlog, so i might be a bit on that. hypothesis is that you probably want to look at how the UI gets refreshed when that particular element is loaded, then find a way to call that same refresh method after the sprite dummy is loaded |
|
marking this as a draft again because of the unending xml agony |
3 participants
About the PR
draft cause there are still some mysterious issues, but this fixes the thing where anomalocarids get cut off in the character creation screen. also includes some adjustments to their offsets to (finally) make them look perfect.
Technical details
this adds a minsize to the character dummy, which as far as i can tell mostly doesn't have any knock on effects (?) i tested this at multiple screen resolutions and they all looked fine
Media
Requirements