Conversation
Collaborator
Author
|
script that creates entries: https://github.com/openmsi/misc_scripts/blob/main/RVE/create_and_fill_form.ipynb
|
Contributor
|
I think we've been through this on a separate form (laser shock perhaps? can't find my comment). In my personal opinion, having long, complicated property names full of spaces and special characters is a no-go. You go to extremes here, e.g.: where property name is actually longer than its description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this notebook to extract and understand content from the various files expected under each Case_XX folder:
📎 https://github.com/openmsi/misc_scripts/blob/main/populate_rve_schema.ipynb
TODOs
Verify the structure of all, but especially:
Double-check units
Refine and confirm field descriptions
Decide which fields should be required vs optional
Notes
It’s not clear if the files under loading/inputFiles/ in a given Case_XX folder represent a single experiment, since some of them also appear in folders like loading/analysis_{DATE}. If these represent multiple experiments, we may need to allow lists of file uploads for those cases. Similarly, this applies to extraction logic for files under that folder, like materialProperties.inp.
We need to determine:
Some files (e.g. materialProperties.inp) contain a lot of detailed data and might be better treated as raw file uploads, rather than trying to parse and map all their contents into fields.