Skip to content

!!![BUGFIX] Fix fetching TypoScript in informReceivers #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sypets wants to merge 1 commit into
base: main
Choose a base branch
from
Open

!!![BUGFIX] Fix fetching TypoScript in informReceivers #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions Classes/Command/InformReceiversCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,18 @@
use In2code\PowermailCleaner\Service\TimeCalculationService;
use Psr\Log\LoggerInterface;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Mailer\Exception\TransportExceptionInterface;
use Symfony\Component\Mime\Address;
use TYPO3\CMS\Core\Http\ServerRequest;
use TYPO3\CMS\Core\Mail\FluidEmail;
use TYPO3\CMS\Core\Mail\MailerInterface;
use TYPO3\CMS\Core\Service\FlexFormService;
use TYPO3\CMS\Core\Utility\ArrayUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Extbase\Configuration\BackendConfigurationManager;
use TYPO3\CMS\Extbase\Configuration\ConfigurationManager;
use TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface;

Expand All @@ -34,9 +37,10 @@ class InformReceiversCommand extends Command

public function __construct(
private readonly LoggerInterface $logger,
private readonly BackendConfigurationManager $backendConfigurationManager,
) {
parent::__construct();
$this->powermailCleanerTyposcript = $this->getTypoScriptConfiguration();

/** @var MailRepository $mailRepository */
$this->mailRepository = GeneralUtility::makeInstance(MailRepository::class);
/** @var FlexFormService $flexFormService */
Expand All @@ -48,7 +52,8 @@ public function __construct(

protected function configure(): void
{
$this->setHelp('Informs receivers about the deletion of emails');
$this->setHelp('Informs receivers about the deletion of emails')
->addArgument('target-page', InputArgument::REQUIRED, 'Must pass target page to fetch TypoScript');
}

/**
Expand All @@ -57,6 +62,13 @@ protected function configure(): void
*/
protected function execute(InputInterface $input, OutputInterface $output): int
{
$targetPage = (int) $input->getArgument('target-page');
if ($targetPage < 1) {
$output->error('Target page must be greater than 1');
return 1;
}
$this->powermailCleanerTyposcript = $this->getTypoScriptConfiguration($targetPage);

if (empty($this->powermailCleanerTyposcript)) {
$output->writeln('Powermail Cleaner: TypoScript configuration missing');
$this->logger->critical('Powermail Cleaner: TypoScript configuration missing');
Expand Down Expand Up @@ -98,16 +110,11 @@ private function getAllPowermailPi1PluginsWithDeletionRestriction(): array
return $powermailPi1PluginsWithDeletionRestrictions;
}

private function getTypoScriptConfiguration(): array
private function getTypoScriptConfiguration(int $targetPageId): array
{
$configurationManager = GeneralUtility::makeInstance(ConfigurationManager::class);
$typoscript = $configurationManager->getConfiguration(
ConfigurationManagerInterface::CONFIGURATION_TYPE_FULL_TYPOSCRIPT
);
return
!empty($typoscript['plugin.']['tx_powermail_cleaner.']['settings.'])
? $typoscript['plugin.']['tx_powermail_cleaner.']['settings.']
: [];
$request = (new ServerRequest())->withQueryParams(['id' => $targetPageId]);
$typoScriptSetup = $this->backendConfigurationManager->getTypoScriptSetup($request);
return $typoScriptSetup['plugin.']['tx_powermail_cleaner.']['settings.'] ?? [];
}

private function findReceivers(array $flexform): array
Expand Down