fix: restore outbound CID attachment support#171
Open
R44VC0RP wants to merge 2 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1cf9e8b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
content_idsupport for send and reply attachment schemasVerification
bun test app/api/e2/helper/email-builder.test.tsbunx biome lint app/api/e2/emails/send.ts app/api/e2/emails/reply.ts app/api/e2/helper/attachment-processor.ts app/api/e2/helper/email-builder.ts app/api/e2/helper/email-builder.test.ts app/api/e2/helper/main.ts app/api/e2/lib/auth.ts lib/api-types.tsbun run generate:openapigit diff --check origin/main...HEADNotes
bun run lintstill reports existing diagnostics outside this change set.Note
Medium Risk
Changes affect production email send/reply and MIME construction (SSRF, header injection, encoding); mitigations are tested but any MIME regression could break delivery or threading.
Overview
Restores inline CID attachments (
content_id) on send/reply APIs and keeps CID metadata through processing, storage, and multipart/related MIME via the sharedbuildRawEmailMessagepath (reply no longer builds raw MIME inline).Security and correctness on the outbound pipeline: SSRF checks and no redirects for remote attachment URLs, stricter
content_idvalidation, pre-decode base64 size limits, header/MIME injection sanitization and real quoted-printable encoding inemail-builder, plus API key values redacted in logs. Shared imports/types tightened (ProcessedAttachment, schedule parsing).Adds
email-builder.test.tscovering CID MIME, injection hardening, and QP encoding; updates publicAttachmentInputtypes.Reviewed by Cursor Bugbot for commit 6b94cfe. Bugbot is set up for automated code reviews on this repo. Configure here.