fix(ui): restore cursor and autowrap when install/migrate aborts#290
Merged
fix(ui): restore cursor and autowrap when install/migrate aborts#290
Conversation
Anchor MultiProgress.finish to scope exit on the install path and route panic through a wrapper that restores the cursor + autowrap before abort. Without this, an early return or panic between init and join leaves the terminal in DECRESET until the user runs `reset` or `stty sane`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Today, an early return or a panic between
MultiProgress.initand its pairedfinishleaves the terminal with autowrap disabled and the cursor hidden until the user runsresetorstty sane. The visible cost is small but the surprise is real, since it can outlive the failing command.This wires two complementary safety nets so the terminal is always handed back in a usable state:
installdownload phase now anchorsMultiProgress.finishto scope exit, matching whatmigratealready does. Any error path or--quiet/dry-run early return between init and the worker join restores the cursor, instead of relying on the explicit call at the bottom of the block.Related Issue
Notes for Reviewers
FullPanicoversimple_panic);