fix(dsl/fallback_log): warn when an OOM drops a fallback entry#291
Merged
fix(dsl/fallback_log): warn when an OOM drops a fallback entry#291
Conversation
Surface a one-line stderr warning when the diagnostic log fails to grow so the user keeps the signal that a post_install was partially skipped under memory pressure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the DSL fallback log itself runs out of memory while appending an entry, the user keeps a one-line stderr warning instead of a silent drop. The signal that a
post_installwas partially skipped during a largemt migrateno longer disappears under memory pressure; the entry is still dropped, but the diagnostic surface stays loud.Related Issue
Notes for Reviewers