Skip to content

Conversation

@adamdickmeiss
Copy link
Contributor

@adamdickmeiss adamdickmeiss commented Jan 16, 2026

Copilot AI review requested due to automatic review settings January 16, 2026 10:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the directory API specification and related code by moving it from a nested location (illmock/directory) to a top-level module (directory). This promotes the directory service to a first-class module that can be independently consumed by other parts of the codebase.

Changes:

  • Moved directory OpenAPI specification and configuration from illmock/directory to top-level directory module
  • Updated import paths across the codebase from github.com/indexdata/crosslink/illmock/directory to github.com/indexdata/crosslink/directory
  • Added directory as a separate Go module with its own go.mod and build configuration

Reviewed changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
directory/go.mod New Go module file for the directory package
directory/go.sum Dependency checksums for the directory module
directory/directory_api.yaml Moved OpenAPI specification defining directory entries API
directory/directory_config.yaml Updated oapi-codegen configuration with corrected output path
directory/examples/directory.json Example directory data moved to new location
directory/Makefile New Makefile for generating code and running tests in directory module
go.work Added directory module to workspace
Makefile Added directory to the build order before illmock
illmock/go.mod Added directory module as a dependency
illmock/Makefile Removed directory generation tasks (now handled by directory module)
illmock/dirmock/dirmock.go Updated import path to new directory location
illmock/dirmock/dirmock_test.go Updated import path to new directory location
illmock/app/app_test.go Updated import path to new directory location

@adamdickmeiss adamdickmeiss merged commit 071211a into main Jan 16, 2026
4 checks passed
@adamdickmeiss adamdickmeiss deleted the CROSSLINK-199 branch January 16, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants