Skip to content

fix(app): dead ⌘V — accessory app had no main menu to route edit shortcuts #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
initcore0 merged 1 commit into from
Aug 2, 2026
Merged

fix(app): dead ⌘V — accessory app had no main menu to route edit shortcuts #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions OpenWhisp/AppMain.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ class OpenWhispApp: NSObject, NSApplicationDelegate {
NSApp.setActivationPolicy(.accessory)
print("[OpenWhisp] ActivationPolicy set to .accessory")

// A standard main menu with an EDIT menu. Accessory (menu-bar) apps get
// no menu bar UI, but macOS still routes ⌘V/⌘C/⌘X/⌘A/⌘Z through the
// main menu's key equivalents — without one, paste is DEAD in every
// window (the Scratchpad bug). Standard selectors ride the responder
// chain, so this fixes all text fields app-wide.
NSApp.mainMenu = Self.makeMainMenu()

// Initialize state
appState = AppState.shared
print("[OpenWhisp] AppState initialized")
Expand Down Expand Up @@ -159,6 +166,34 @@ class OpenWhispApp: NSObject, NSApplicationDelegate {
onboardingWindow = window
}

/// The invisible main menu that makes standard edit shortcuts work.
private static func makeMainMenu() -> NSMenu {
let main = NSMenu()

let appItem = NSMenuItem()
let appMenu = NSMenu()
appMenu.addItem(NSMenuItem(title: "Quit OpenWhisp",
action: #selector(NSApplication.terminate(_:)), keyEquivalent: "q"))
appItem.submenu = appMenu
main.addItem(appItem)

let editItem = NSMenuItem()
let edit = NSMenu(title: "Edit")
edit.addItem(NSMenuItem(title: "Undo", action: Selector(("undo:")), keyEquivalent: "z"))
let redo = NSMenuItem(title: "Redo", action: Selector(("redo:")), keyEquivalent: "z")
redo.keyEquivalentModifierMask = [.command, .shift]
edit.addItem(redo)
edit.addItem(.separator())
edit.addItem(NSMenuItem(title: "Cut", action: #selector(NSText.cut(_:)), keyEquivalent: "x"))
edit.addItem(NSMenuItem(title: "Copy", action: #selector(NSText.copy(_:)), keyEquivalent: "c"))
edit.addItem(NSMenuItem(title: "Paste", action: #selector(NSText.paste(_:)), keyEquivalent: "v"))
edit.addItem(NSMenuItem(title: "Select All",
action: #selector(NSText.selectAll(_:)), keyEquivalent: "a"))
editItem.submenu = edit
main.addItem(editItem)
return main
}

/// Menu-bar icon: the bundled waveform glyph (template, so macOS tints it for
/// light/dark menu bars) that matches the app icon. Falls back to the SF
/// `waveform` symbol if the bundled image isn't present.
Expand Down
Loading