Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces baseline continuous integration for the pushwork Node/TypeScript project, and adds a minimal ESLint setup so linting can run as part of CI.
Changes:
- Add a GitHub Actions workflow that installs dependencies and runs typecheck, lint, build, and tests on pushes and pull requests.
- Add an ESLint flat config (TypeScript-focused) and update package scripts/dependencies to support linting.
- Update
pnpm-lock.yamlto include ESLint and TypeScript-ESLint dependencies.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pnpm-lock.yaml |
Locks newly added eslint + typescript-eslint dependency graph. |
package.json |
Adds lint dependencies and simplifies lint scripts to work with flat config. |
eslint.config.mjs |
Introduces a minimal flat ESLint configuration using typescript-eslint. |
.github/workflows/ci.yml |
Adds CI workflow running typecheck, lint, build, and test via pnpm. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
expede
commented
May 13, 2026
| await Promise.allSettled([modifyPromise, deletePromise]); | ||
|
|
||
| // File should be deleted regardless of modification timing | ||
| expect(await pathExists(filePath)).toBe(false); |
Member
Author
There was a problem hiding this comment.
This tests is flaky in CI
expede
commented
May 13, 2026
| @@ -1,830 +0,0 @@ | |||
| /** | |||
| * Sync Reliability Tests | |||
Member
Author
There was a problem hiding this comment.
Ironically very flaky. Most of these now have equivalents in the --sub tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just what it says on the tin 🥫
I noticed that tests were failing on
mainlocally, which makes it difficult to have confidence in changes. This PR doesn't get tests passing, but does give us feedback during the PR process.