memory optimization for aggregator #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of optimizations regarding memory allocation, reducing lock contention in pauses aggregator:
MatchResultwas flattened from a nested map to a singlemap[matchKey]int, removed mutex from it so it's no longer thread safe but the synchronization overhead of multiple goroutines writing to it likely outweighed the parallelism gains.sync.PoolforMatchResultto reduce allocations per eval.Remove()is now O(1): just stores the ID of the deleted evaluable in a sync.Map. A background gcWorker goroutine periodically drains the deleted set in batches so that we never block evaluations for long periods. EngineRemove()also takes a batch now, single lock acquisition per batch.rand.Randcan also be pooled via sync.Pool in the parser.