Skip to content

Fix default testing depth #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
averissimo merged 2 commits into from
Jan 7, 2026
Merged

Fix default testing depth #296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f26580b
Fallback to testing depth 5
averissimo Dec 19, 2025
e89d546
chore: make the PR agnostic of the target branch
averissimo Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/build-check-install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,6 @@ jobs:
uses: tj-actions/changed-files@a284dc1814e3fd07f2e34267fc8f81227ed29fb8
with:
path: ${{ github.event.repository.name }}/${{ inputs.package-subdirectory }}
base_sha: "main"
files: |
tests/testthat/*.R
R/*.R
Expand All @@ -553,11 +552,12 @@ jobs:
commit_msg=$( git log -1 --pretty=%B )

# Set default TESTING_DEPTH
td=$TESTING_DEPTH
if [ -z "$td" ]
WORKFLOW_TESTING_DEPTH=$TESTING_DEPTH
if [ -z "$WORKFLOW_TESTING_DEPTH" ]
then {
echo "No TESTING_DEPTH default."
TESTING_DEPTH=5
WORKFLOW_TESTING_DEPTH=5
echo "Setting TESTING_DEPTH=${TESTING_DEPTH}"
echo "TESTING_DEPTH=${TESTING_DEPTH}" >> "$GITHUB_ENV"
} fi
Expand Down Expand Up @@ -606,12 +606,11 @@ jobs:
then {
git restore $test_dir
echo "Run all tests: Helpers modifications detected."
TESTING_DEPTH="${td}";
TESTING_DEPTH="${WORKFLOW_TESTING_DEPTH}";
break;
} else {
sed -i 's/skip_if_too_deep(5)/skip_if_too_deep(3)/g' "$test_files"
TESTING_DEPTH=3
echo "TESTING_DEPTH=${TESTING_DEPTH}" >> "$GITHUB_ENV"
echo "Testing with shinytest2 only for $test_files";
} fi
done
Expand Down
Loading