Skip to content

Fix(aio-pika): Implement argument binding method to extract values from both args and kwargs#802

Merged
pvital merged 2 commits intomainfrom
fix-aiopika
Sep 24, 2025
Merged

Fix(aio-pika): Implement argument binding method to extract values from both args and kwargs#802
pvital merged 2 commits intomainfrom
fix-aiopika

Conversation

@GSVarsha
Copy link
Copy Markdown
Contributor

Fix(aio-pika): Implement argument binding method to extract values from both args and kwargs

Signed-off-by: Varsha GS varsha.gs@ibm.com

@GSVarsha GSVarsha added this to the H2-2025 milestone Sep 23, 2025
@GSVarsha GSVarsha self-assigned this Sep 23, 2025
@GSVarsha GSVarsha added WIP work in progress unittest fix labels Sep 23, 2025
@GSVarsha GSVarsha marked this pull request as ready for review September 24, 2025 07:32
@GSVarsha GSVarsha requested a review from a team as a code owner September 24, 2025 07:32
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests, actually questions.

Comment thread src/instana/instrumentation/aio_pika.py Outdated
Comment thread src/instana/instrumentation/aio_pika.py
@GSVarsha GSVarsha removed the WIP work in progress label Sep 24, 2025
@GSVarsha GSVarsha requested a review from pvital September 24, 2025 09:19
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

…h args and kwargs

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@sonarqubecloud
Copy link
Copy Markdown

@pvital pvital merged commit c28a94e into main Sep 24, 2025
19 checks passed
@pvital pvital deleted the fix-aiopika branch September 24, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants