Conversation
To maintain OpenTelemetry API compliance, this commit changes the `InstanaSpan` to use OTel's `SpanKind` as a parameter during the span creation. This commit fixes #813. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
This commit updates all tests to use the `kind` parameter while creating a new `InstanaSpan` or `ReadableSpan`. This commit fixes #813. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To maintain OpenTelemetry API compliance, this PR changes the Span structure to use OTel's
SpanKindas a parameter while creating a newInstanaSpanorReadableSpan. It also updates the tests.This commit fixes #813.