Updates and PHP 8.1 compatibility#24
Open
soundslocke wants to merge 3 commits intoinstasent:masterfrom
Open
Conversation
- Switch to PHP 8.1 method signatures. - Update required PHP version in composer.json. - Update from `switch` to `match` expression. - Replace array "get" methods with const arrays. - Add visibility to const values. - Remove redundant `Gsm7bitExMap` array. - Avoid juggling `null` in `replaceNonGsmChars()`.
soundslocke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for publishing this library! It is helpful for handling SMS text content.
We created a fork and made some updates as a result of upgrading to PHP 8.1+ and seeing that this library dependency causes deprecation notices.
The following has been done:
switchtomatchexpressions.Gsm7bitExMaparray.nullinreplaceNonGsmChars().Additionally, we've pulled in the commits from PR #20 which seems like a worthwhile improvement to the library that we wanted for our fork. If you would rather merge that PR separately we can drop those commits from here.
If this PR gets merged you'll probably want to make a new major version release of the library since this does break backwards compatibility. Given this discussion about semver we would suggest a
1.0.0release.Resolves #23