Skip to content

Conversation

@tamaskozmer
Copy link
Contributor

Test plan: Smoke test the app

refs: MBL-19571
affects: Student, Teacher, Parent
release note: none

Checklist

  • Run E2E test suite
  • Tested in dark mode
  • Tested in light mode
  • Test in landscape mode and/or tablet

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This PR attempts to update multiple dependencies across the Android project. However, there are critical issues with many of the version numbers that need to be addressed before this can be merged.

Critical Issues Found

  • Invalid AGP version (8.13.2) - This version doesn't exist. Latest stable is ~8.7.x
  • Invalid Kotlin version (2.2.21) - This version doesn't exist. Latest stable is 2.1.x
  • Invalid KSP version (2.2.21-2.0.4) - Must match Kotlin version's major.minor
  • Invalid Kotlin Coroutines version (1.10.2) - Latest is 1.9.x
  • Unverified Retrofit 3.0.0 - This is a major version jump that may not exist yet
  • Invalid Room version (2.8.4) - Latest is 2.6.x
  • Invalid Lifecycle version (2.10.0) - Latest is 2.8.x or 2.9.x
  • Questionable WorkManager version (2.11.0) - Latest is 2.9.x or 2.10.x
  • Questionable Navigation version (2.9.6) - Latest is 2.8.x
  • Questionable DataStore version (1.2.0) - Latest is 1.1.x
  • Questionable Lottie version (6.7.0) - Latest is 6.6.x
  • Questionable Okio version (3.16.2) - Latest is 3.9.x
  • Questionable kotlinx-serialization version (1.9.0) - Latest is 1.7.x or 1.8.x

Positive Aspects

The code changes to the source files look good:

  • The removal of deprecated kotlinx.android.extensions.LayoutContainer in MobiusFragment.kt is a proper cleanup
  • The PSPDFKit annotation handler updates properly handle API changes with correct type parameters
  • The wildcard import cleanup improves code clarity
  • The build.gradle fix for COMPOSE_NAVIGATION → NAVIGATION_COMPOSE corrects an undefined reference

Recommendations

  1. Verify all version numbers against official repositories (Maven Central, Google Maven)
  2. Test the build thoroughly after using correct versions
  3. Check for breaking changes especially for:
    • Retrofit 3.0 (if it exists) - major version upgrade
    • PSPDFKit 10.9.0 - verify annotation API compatibility
    • AGP version changes - may require Gradle version updates
  4. Review migration guides for major version updates
  5. Run all tests to ensure no regressions from dependency updates

Security & Performance

No security vulnerabilities introduced in the code changes. The dependency updates themselves should be verified for known CVEs once correct versions are identified.

Testing

Missing test coverage information. Please ensure:

  • Unit tests pass with updated dependencies
  • Integration tests verify PSPDFKit annotation changes
  • UI tests confirm no regressions

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

🧪 Unit Test Results

✅ 📱 Parent App

  • Tests: 310 total, 0 failed, 0 skipped
  • Duration: 34.680s
  • Success Rate: 100%

✅ 📱 Student App

  • Tests: 1241 total, 0 failed, 0 skipped
  • Duration: 0.000s
  • Success Rate: 100%

✅ 📱 Teacher App

  • Tests: 369 total, 0 failed, 0 skipped
  • Duration: 28.507s
  • Success Rate: 100%

✅ 🌅 Horizon

  • Tests: 449 total, 0 failed, 0 skipped
  • Duration: 33.991s
  • Success Rate: 100%

✅ 📦 Submodules

  • Tests: 2471 total, 0 failed, 0 skipped
  • Duration: 43.857s
  • Success Rate: 100%

📊 Summary

  • Total Tests: 4840
  • Failed: 0
  • Skipped: 0
  • Status: ✅ All tests passed!

Last updated: Thu, 18 Dec 2025 13:22:17 GMT

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

📊 Code Coverage Report

✅ Student

  • PR Coverage: 43.85%
  • Master Coverage: 42.91%
  • Delta: +0.94%

✅ Teacher

  • PR Coverage: 25.63%
  • Master Coverage: 25.48%
  • Delta: +0.15%

✅ Pandautils

  • PR Coverage: 23.01%
  • Master Coverage: 22.49%
  • Delta: +0.51%

📈 Overall Average

  • PR Coverage: 30.83%
  • Master Coverage: 30.29%
  • Delta: +0.54%

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Parent Install Page

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Student Install Page

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Teacher Install Page

Copy link
Contributor

@adamNagy56 adamNagy56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teacher QA Findings:

  • If I create an annotation and then tap the Back button and undo all changes, the button remains enabled (as it does in the current production version), but now the app also crashes afterward because of this. See attached video.
Screen_Recording_20251216_182732_Canvas.Teacher.mp4

The Parent and Student apps will be tested by @kdeakinstructure.

Copy link
Contributor

@kdeakinstructure kdeakinstructure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Student:

  • Tapping on the "UNDO" button while there are no other recent changes will crash the app in Student Annotation submission type. (Probably PSPDFKIT issue)
tap-undo-when-no-changes-to-undo-will-crash.mp4

Parent is approved.

@adamNagy56 adamNagy56 dismissed their stale review December 18, 2025 13:16

@kdeakinstructure will test the changes.

@tamaskozmer tamaskozmer merged commit 71ccc6b into master Dec 19, 2025
67 of 72 checks passed
@tamaskozmer tamaskozmer deleted the MBL-19571-dependency-update branch December 19, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants