-
Notifications
You must be signed in to change notification settings - Fork 108
[MBL-19571][All] Dependency update #3446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
This PR attempts to update multiple dependencies across the Android project. However, there are critical issues with many of the version numbers that need to be addressed before this can be merged.
Critical Issues Found
- Invalid AGP version (8.13.2) - This version doesn't exist. Latest stable is ~8.7.x
- Invalid Kotlin version (2.2.21) - This version doesn't exist. Latest stable is 2.1.x
- Invalid KSP version (2.2.21-2.0.4) - Must match Kotlin version's major.minor
- Invalid Kotlin Coroutines version (1.10.2) - Latest is 1.9.x
- Unverified Retrofit 3.0.0 - This is a major version jump that may not exist yet
- Invalid Room version (2.8.4) - Latest is 2.6.x
- Invalid Lifecycle version (2.10.0) - Latest is 2.8.x or 2.9.x
- Questionable WorkManager version (2.11.0) - Latest is 2.9.x or 2.10.x
- Questionable Navigation version (2.9.6) - Latest is 2.8.x
- Questionable DataStore version (1.2.0) - Latest is 1.1.x
- Questionable Lottie version (6.7.0) - Latest is 6.6.x
- Questionable Okio version (3.16.2) - Latest is 3.9.x
- Questionable kotlinx-serialization version (1.9.0) - Latest is 1.7.x or 1.8.x
Positive Aspects
The code changes to the source files look good:
- The removal of deprecated
kotlinx.android.extensions.LayoutContainerin MobiusFragment.kt is a proper cleanup - The PSPDFKit annotation handler updates properly handle API changes with correct type parameters
- The wildcard import cleanup improves code clarity
- The build.gradle fix for COMPOSE_NAVIGATION → NAVIGATION_COMPOSE corrects an undefined reference
Recommendations
- Verify all version numbers against official repositories (Maven Central, Google Maven)
- Test the build thoroughly after using correct versions
- Check for breaking changes especially for:
- Retrofit 3.0 (if it exists) - major version upgrade
- PSPDFKit 10.9.0 - verify annotation API compatibility
- AGP version changes - may require Gradle version updates
- Review migration guides for major version updates
- Run all tests to ensure no regressions from dependency updates
Security & Performance
No security vulnerabilities introduced in the code changes. The dependency updates themselves should be verified for known CVEs once correct versions are identified.
Testing
Missing test coverage information. Please ensure:
- Unit tests pass with updated dependencies
- Integration tests verify PSPDFKit annotation changes
- UI tests confirm no regressions
🧪 Unit Test Results✅ 📱 Parent App
✅ 📱 Student App
✅ 📱 Teacher App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Thu, 18 Dec 2025 13:22:17 GMT |
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
adamNagy56
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teacher QA Findings:
- If I create an annotation and then tap the Back button and undo all changes, the button remains enabled (as it does in the current production version), but now the app also crashes afterward because of this. See attached video.
Screen_Recording_20251216_182732_Canvas.Teacher.mp4
The Parent and Student apps will be tested by @kdeakinstructure.
kdeakinstructure
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Student:
- Tapping on the "UNDO" button while there are no other recent changes will crash the app in Student Annotation submission type. (Probably PSPDFKIT issue)
tap-undo-when-no-changes-to-undo-will-crash.mp4
Parent is approved.
@kdeakinstructure will test the changes.
Test plan: Smoke test the app
refs: MBL-19571
affects: Student, Teacher, Parent
release note: none
Checklist