feat: add sensitive data detection rules (RES-010, SPA-006, LOG-003)#52
Conversation
Propose three new Critical rules that detect sensitive data leaking through telemetry attributes and log record bodies, covering PII, financial identifiers, credentials, and health information. Closes instrumentation-score#51 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I think this is a case for "Ad Omnia" rules: you should not have sensitive data anywhere in your telemetry. For example, why would it be acceptable to have PII in log attributes or metrics datapoint attributes (or metrics name or unit!) |
Summary
Propose three new Critical rules that detect sensitive data leaking through telemetry:
process.command_args)db.query.text,url.full)Each rule covers the same categories of sensitive data — personal identifiers, financial data, credentials & secrets, and health data — with target-specific criteria and examples.
Motivation
Telemetry data is typically stored in observability backends with broader access than production databases. Sensitive data in telemetry creates compliance risks (GDPR, HIPAA, PCI-DSS) and security vulnerabilities. The OTel Semantic Conventions explicitly discourage recording sensitive information, but the spec has no rule flagging it.
Open questions
service.data_sensitivity— complementary but distinct.Test plan
_template.mdCloses #51
🤖 Generated with Claude Code