Fix protocol converter crash on EVALUATE frame define#328
Merged
Conversation
Remove unused Discord webhooks. Strip branch filter so the converter runs on every push, but gate the deploy and documentation steps behind a master-only check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…_internal Align with the _frame_start/_frame_end naming convention used by other classes. The previous name caused protocol_converter.py to match it as a class param and crash trying to cast ".." to int. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GRID_CLASS_EVALUATE_ELEMENT_frametoGRID_CLASS_EVALUATE_frame_internalto align with the_frame_start/_frame_endnaming convention used by other classesprotocol_converter.pyto match it as a class param and crash withValueErrorwhen trying to cast".."toint🤖 Generated with Claude Code