Skip to content

kk update context target to svelte 5 syntax #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkerti merged 1 commit into from
Feb 6, 2026
Merged

kk update context target to svelte 5 syntax #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/lib/context-target.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,23 @@
import type { Action } from "svelte/action";
import ContextMenu, { type ContextMenuItem } from "./ContextMenu.svelte";
import { mount, unmount } from "svelte";
import { get, writable, type Writable } from "svelte/store";

export interface ContextMenuOptions {
items: ContextMenuItem[];
}

interface ContextMenuWritable extends Writable<ContextMenu | undefined> {
interface ContextMenuStore extends Writable<Record<string, any> | undefined> {
close: () => void;
}

export let contextMenu: ContextMenuWritable = createContextMenuStore();

function createContextMenuStore(): ContextMenuWritable {
const store: Writable<ContextMenu | undefined> = writable(undefined);
function createContextMenuStore(): ContextMenuStore {
const store: Writable<Record<string, any> | undefined> = writable(undefined);

const close = () => {
const cm = get(store);
if (cm) {
cm.$destroy(); // Ensure that the context menu has a $destroy method
unmount(cm);
store.set(undefined);
}
};
Expand All @@ -29,6 +28,8 @@ function createContextMenuStore(): ContextMenuWritable {
};
}

export const contextMenu: ContextMenuStore = createContextMenuStore();

export const contextTarget: Action<HTMLElement, ContextMenuOptions> = (
node: HTMLElement,
options: ContextMenuOptions,
Expand All @@ -45,7 +46,7 @@ export const contextTarget: Action<HTMLElement, ContextMenuOptions> = (
contextMenu.close();

contextMenu.set(
new ContextMenu({
mount(ContextMenu, {
target: document.body,
props: {
target: node,
Expand Down