WIP: Add data sources for hosted runner custom images#3286
Draft
austenstone wants to merge 2 commits intointegrations:mainfrom
Draft
WIP: Add data sources for hosted runner custom images#3286austenstone wants to merge 2 commits intointegrations:mainfrom
austenstone wants to merge 2 commits intointegrations:mainfrom
Conversation
Add three new data sources for managing custom images on GitHub-hosted runners: - github_actions_hosted_runner_custom_images: List all custom images for an org - github_actions_hosted_runner_custom_image: Get a single custom image definition - github_actions_hosted_runner_custom_image_versions: List versions of a custom image WIP: Blocked on google/go-github#4101 merging. Currently uses raw HTTP calls via the v3client to avoid a go-github version bump. Once the go-github PR lands and is released, these can be migrated to typed SDK methods. Includes acceptance tests, provider registration, and website docs.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add three new data sources for managing custom images on GitHub-hosted runners:
github_actions_hosted_runner_custom_imagesGET /orgs/{org}/actions/hosted-runners/images/customgithub_actions_hosted_runner_custom_imageGET /orgs/{org}/actions/hosted-runners/images/custom/{id}github_actions_hosted_runner_custom_image_versionsGET /orgs/{org}/actions/hosted-runners/images/custom/{id}/versionsBlocked On
Current Approach
Uses raw HTTP calls via
client.NewRequest/client.Do(same pattern as the existinggithub_actions_hosted_runnerresource) to avoid a go-github version bump until the upstream PR merges and releases.Once
go-githubreleases with the custom image endpoints, these data sources can be migrated to use the typed SDK methods.What's Included
provider.goNew Types from go-github PR
Related