Skip to content

[SYCL][Graph] Adding new graph enqueue function to spec#15677

Merged
aelovikov-intel merged 20 commits into
intel:syclfrom
reble:pablo/graph_enqueue_functions
Nov 6, 2024
Merged

[SYCL][Graph] Adding new graph enqueue function to spec#15677
aelovikov-intel merged 20 commits into
intel:syclfrom
reble:pablo/graph_enqueue_functions

Conversation

@reble
Copy link
Copy Markdown
Contributor

@reble reble commented Oct 11, 2024

replacing #15385 after offline discussion.

@reble reble marked this pull request as ready for review October 22, 2024 19:39
@reble reble requested review from a team as code owners October 22, 2024 19:39
@reble reble requested a review from aelovikov-intel October 22, 2024 19:39
Copy link
Copy Markdown
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we anticipate the need to pass any compile-time properties to these methods in future?

@EwanC
Copy link
Copy Markdown
Contributor

EwanC commented Oct 23, 2024

Do we anticipate the need to pass any compile-time properties to these methods in future?

This PR modifies the submit/submit_with_event entry-point to add variants with the extra properties parameters #15704, I think we should be consistent with that and have a way to pass properties.

Comment thread sycl/doc/extensions/experimental/sycl_ext_oneapi_enqueue_functions.asciidoc Outdated
Copy link
Copy Markdown
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec changes LGTM.

Comment thread sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc Outdated
Comment thread sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc Outdated
@reble
Copy link
Copy Markdown
Contributor Author

reble commented Nov 6, 2024

Do we anticipate the need to pass any compile-time properties to these methods in future?

This PR modifies the submit/submit_with_event entry-point to add variants with the extra properties parameters #15704, I think we should be consistent with that and have a way to pass properties.

Graph related functions have been renamed, and there has been a consensus that those variants with extra property parameters are not required for the new functions.

@reble
Copy link
Copy Markdown
Contributor Author

reble commented Nov 6, 2024

@intel/llvm-gatekeepers This PR can be merged. Thanks!

@sarnex
Copy link
Copy Markdown
Contributor

sarnex commented Nov 6, 2024

This needs a review from @intel/llvm-reviewers-runtime

@reble reble requested a review from aelovikov-intel November 6, 2024 17:27
@aelovikov-intel aelovikov-intel merged commit 66867d4 into intel:sycl Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants