[SYCL] Stop building and installing spirv format device library files #20921
Conversation
Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
…s as well. Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hi, @uditagarwal97 |
| - name: check-libdevice | ||
| if: ${{ !cancelled() && contains(inputs.changes, 'sycl') }} | ||
| run: | | ||
| cmake --build $GITHUB_WORKSPACE/build --target check-libdevice |
There was a problem hiding this comment.
Hi @jinge90 ,
Sorry, I didn't get why we no longer want to run libdevice tests in CI? Are all tests executed as part of check-libdevice target useless now?
There was a problem hiding this comment.
Hi, @uditagarwal97
Yes, these tests are useless now. There are 2 parts of libdevice tests: SYCL/test-e2e/DeviceLib and libdevice/test.
The SYCL/test-e2e/DeviceLib includes all functionality e2e tests and libdevice/test(check-libdevice) is lit test to check spirv format device library files only. For example, we will use 'llvm-spirv -r' to translate spirv device library files to LLVM IR file and check whether 'double' type exits only in math/complex device libraries targets for fp64.
For now, we have removed the spirv device library jit link path in SYCL compiler, those spirv device libraries are useless now and should be removed from compiler package. So, the lit tests checking spirv device libraries should be removed together.
There is no change for SYCL/test-e2e/DeviceLib, all device library e2e tests are still ran in CI.
Thanks very much.
There was a problem hiding this comment.
Ahh.. I see. Makes sense now.
There was a problem hiding this comment.
@jinge90 In that case, should we also remove check-libdevice CMake target?
| set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") | ||
| endif() | ||
|
|
||
| add_lit_testsuite(check-libdevice "Running the libdevice regression tests" |
There was a problem hiding this comment.
Hi, @uditagarwal97
The check-libdevice target has been removed here.
Thanks very much.
2 participants
SYCL device library jit link path has been removed, there is no value building and installing spirv format device libraries. This PR removes all spirv device library related things in device library cmake file.