[Bench] Add TorchSlmSize benchmark #20937
Open
+109
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
reviewed
Dec 18, 2025
| "max", | ||
| batchSize=512, | ||
| slmNum=-1, | ||
| warmupIterations=2, |
Contributor
There was a problem hiding this comment.
I'm not sure if we are interested in having scenarios with varying warmup iterations. I would go for one value that makes results variance minimal.
Contributor
Author
There was a problem hiding this comment.
heh, well, I was even planning on removing this param from Slm benchmark in CB repo 😉 thx!
lukaszstolarczuk
force-pushed
the
add-torch-slm-bench
branch
2 times, most recently
from
5e6ae8f to
bbadbcb
Compare
lukaszstolarczuk
force-pushed
the
add-torch-slm-bench
branch
from
bbadbcb to
0037a75
Compare
PatKamin
reviewed
Dec 19, 2025
| "small", | ||
| batchSize=512, | ||
| slmNum=1, | ||
| warmupIterations=1, |
Contributor
There was a problem hiding this comment.
Move warmupIterations into createTorchSlmSizeBench as it doesn't change now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add verbose option to bench's integration tests.