[UR][CUDA] Mark MAX_READ_WRITE_IMAGE_ARGS as optional query#21601
Draft
[UR][CUDA] Mark MAX_READ_WRITE_IMAGE_ARGS as optional query#21601
Conversation
kekaczma
force-pushed
the
fix-cuda-max-read-write-image-args
branch
5 times, most recently
from
2c6c6ac to
d7e31c2
Compare
CUDA does not support read-write images in the same sense as OpenCL. CUDA has separate concepts: - Texture objects (read-only) - Surface objects (read-only/write via surfaces) These are distinct API types and cannot be used as a single 'read-write' image argument to a kernel, which is what MAX_READ_WRITE_IMAGE_ARGS queries. Changes: 1. Mark MAX_READ_WRITE_IMAGE_ARGS as [optional-query] in device.yml spec 2. Add explanatory comment to device.yml describing why this is optional 3. Regenerate ur_api.h and optional_queries.h from spec 4. Remove xfails for CUDA and NativeCPU from SuccessMaxReadWriteImageArgs test The CUDA adapter returns UNSUPPORTED_ENUMERATION for this query, which is now correctly handled as an optional feature by the conformance test. NativeCPU also returns UNSUPPORTED_ENUMERATION as it has no IL/image support. Tests now pass for both adapters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDA does not support read-write images in the same sense as OpenCL. CUDA has separate concepts:
These are distinct API types and cannot be used as a single 'read-write' image argument to a kernel, which is what MAX_READ_WRITE_IMAGE_ARGS queries.
Changes:
The CUDA adapter returns UNSUPPORTED_ENUMERATION for this query, which is now correctly handled as an optional feature by the conformance test.
Test now passes for CUDA adapter.