[UR] Remove urKernelSet*() and urEnqueueKernelLaunch() API#21607
Open
ldorau wants to merge 6 commits intointel:syclfrom
Open
[UR] Remove urKernelSet*() and urEnqueueKernelLaunch() API#21607ldorau wants to merge 6 commits intointel:syclfrom
ldorau wants to merge 6 commits intointel:syclfrom
Conversation
1 task
ldorau
force-pushed
the
Remove_urKernelSet_functions
branch
10 times, most recently
from
c01a119 to
9b4840d
Compare
ldorau
changed the title
ldorau
requested review from
adamfidel,
kswiecicki,
kweronsx,
pbalcer and
uditagarwal97
Contributor
Author
|
Please review @intel/dpcpp-nativecpu-reviewers, @intel/llvm-reviewers-cuda, @intel/llvm-reviewers-runtime, @intel/sycl-graphs-reviewers, @intel/unified-runtime-reviewers, @intel/unified-runtime-reviewers-level-zero, and/or @intel/unified-runtime-reviewers-opencl @pbalcer @kswiecicki |
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
…ated source Commit output of `make generate`. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
…h() API Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Add comments about what the "saxpy" name stands for in all places where the saxpy_* variables are declared. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Contributor
Author
|
The |
Remove the public API wrapper functions urKernelSetArgValue(), urKernelSetArgPointer(), urKernelSetArgMemObj(), urKernelSetArgLocal(), and urKernelSetArgSampler() from the Level Zero v2 adapter kernel.cpp. These functions were the public entry points for the removed urKernelSetArg*() APIs. Since those APIs have been removed from the spec, generated code, and DDI tables, these wrapper functions are unreachable dead code. The internal helper methods they called (hKernel->setArgValue(), hKernel->addPendingMemoryAllocation(), etc.) are still used by the OLD fallback path in appendKernelLaunchWithArgsExpOld() and are retained. Also removes the static memAccessFromMemFlags() helper that was only used by the removed urKernelSetArgMemObj() wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove urKernelSet*() and urEnqueueKernelLaunch() API.
Replace urEnqueueKernelLaunch() with urEnqueueKernelLaunchWithArgsExp().