[SYCL] Add test to cover std::complex<float/double> mul/div#21622
Open
jinge90 wants to merge 24 commits intointel:syclfrom
Open
[SYCL] Add test to cover std::complex<float/double> mul/div#21622jinge90 wants to merge 24 commits intointel:syclfrom
jinge90 wants to merge 24 commits intointel:syclfrom
Conversation
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Contributor
Author
|
Hi, @intel/llvm-reviewers-runtime and @sergey-semenov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libdevice provides __mulsc3, __divsc3, __muldc3, __divdc3 to support complex number multiplication and division in 'no-fast-math' mode on Linux platform only. These 4 builtins are not invoked by user code but inserted by compiler when handling complex mul/div expression. This PR adds e2e test for these builtins explicitly, the testing logic is ported from compiler-rt test suite for normal CPU platform:
https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/builtins/Unit/divsc3_test.c
https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/builtins/Unit/divdc3_test.c
https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/builtins/Unit/mulsc3_test.c
https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/builtins/Unit/muldc3_test.c