[UR] Fix validation of arguments of urKernelLaunchWithArgsExp()#21628
Merged
kswiecicki merged 1 commit intointel:syclfrom Mar 26, 2026
Merged
Conversation
The validation layer in ur_valddi.cpp (generated from YAML spec) checked pGlobalWorkSize[0], [1], and [2] and pLocalWorkSize[0], [1], and [2] regardless of workDim. For 1D kernels, indices [1] and [2] read out-of-bounds memory, causing spurious UR_RESULT_ERROR_INVALID_WORK_DIMENSION errors. Removed the hardcoded 3-element validation expressions for pGlobalWorkSize and pLocalWorkSize that couldn't account for workDim. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
changed the title
pbalcer
approved these changes
Mar 26, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
Author
|
@intel/llvm-gatekeepers please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation layer in ur_valddi.cpp (generated from YAML spec)
checked pGlobalWorkSize[0], [1], and [2] and
pLocalWorkSize[0], [1], and [2] regardless of workDim.
For 1D kernels, indices [1] and [2] read out-of-bounds memory,
causing spurious UR_RESULT_ERROR_INVALID_WORK_DIMENSION errors.
Removed the hardcoded 3-element validation expressions
for pGlobalWorkSize and pLocalWorkSize that couldn't account for workDim.