Skip to content

[SYCL] Preserve restrict on free function kernel pointer args #21989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koparasy wants to merge 3 commits into
base: sycl
Choose a base branch
from
+30 −1
Open

[SYCL] Preserve restrict on free function kernel pointer args #21989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8ad402
[SYCL] Preserve restrict on free function kernel pointer args
koparasy May 11, 2026
b16b334
Moved test under appropriate directory
koparasy May 12, 2026
ae9dafe
Fix comment
koparasy May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/Sema/SemaSYCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2477,6 +2477,7 @@ static QualType ModifyAddressSpace(SemaSYCL &SemaSYCLRef, QualType Ty) {
// same type as field but global address space, because OpenCL requires it.
// Function pointers should have program address space. This is set in
// CodeGen.
Qualifiers PtrQuals = Ty.getQualifiers();
QualType PointeeTy = Ty->getPointeeType();
Qualifiers Quals = PointeeTy.getQualifiers();
LangAS AS = Quals.getAddressSpace();
Expand All @@ -2487,7 +2488,8 @@ static QualType ModifyAddressSpace(SemaSYCL &SemaSYCLRef, QualType Ty) {
Quals.setAddressSpace(LangAS::sycl_global);
PointeeTy = SemaSYCLRef.getASTContext().getQualifiedType(
PointeeTy.getUnqualifiedType(), Quals);
return SemaSYCLRef.getASTContext().getPointerType(PointeeTy);
QualType PtrTy = SemaSYCLRef.getASTContext().getPointerType(PointeeTy);
return SemaSYCLRef.getASTContext().getQualifiedType(PtrTy, PtrQuals);
}

// This visitor is used to traverse a non-decomposed record/array to
Expand Down
27 changes: 27 additions & 0 deletions clang/test/CodeGenSYCL/free_function_kernels_restrict.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// RUN: %clang_cc1 -internal-isystem %S/Inputs -fsycl-is-device -triple spir64-unknown-unknown -sycl-std=2020 -emit-llvm %s -o - | FileCheck %s --check-prefix CHECK-IR

#include "sycl.hpp"

// CHECK-IR-DAG: define dso_local spir_func noundef i32 @_Z15helper_restrictPKi(ptr addrspace(4) noalias
__attribute__((sycl_device)) int helper_restrict(const int *__restrict__ input) {
return input[0];
}

// CHECK-IR-DAG: define dso_local spir_func void @_Z25helper_const_ptr_restrictPiPKi(ptr addrspace(4) noalias{{[^,]*}}, ptr addrspace(4) noalias
__attribute__((sycl_device)) void
helper_const_ptr_restrict(int *const __restrict__ output,
const int *const __restrict__ input) {
output[0] = input[0];
}

// CHECK-IR: define dso_local spir_kernel void @_Z43__sycl_kernel_free_function_kernel_restrictPiPKiS_S_S1_PKv(ptr addrspace(1) noalias{{[^,]*}}, ptr addrspace(1) noalias{{[^,]*}}, ptr addrspace(1) {{[^,]*}}, ptr addrspace(1) noalias{{[^,]*}}, ptr addrspace(1) noalias{{[^,]*}}, ptr addrspace(1) noalias
[[__sycl_detail__::add_ir_attributes_function("sycl-single-task-kernel", 0)]]
void free_function_kernel_restrict(int *__restrict__ output,
const int *__restrict__ input, int *plain,
int *const __restrict__ output_const,
const int *const __restrict__ input_const,
const void *const __restrict__ opaque) {
output_const[0] = plain[0];
helper_const_ptr_restrict(output, input_const);
output[0] += helper_restrict(input) + output_const[0] + (opaque != nullptr);
}
Loading