Fix staticheck errors

Linter staticcheck is added through golint-ci.
This update fixes the issues identified by the linter.
Some of these changes have minor impact on control flow especially in
tests.

Author: killianmuldoon

pkg/cache/autoupdating_test.go

@@ -177,11 +177,13 @@ func TestNodeMetricsCache_WriteMetric(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			err := tt.n.WriteMetric(tt.args.metricName, nil)
-			if err == nil && tt.errorExpected {
+			if err != nil && !tt.errorExpected {
+				t.Log(err)
 				t.Fail()
 			}
 			_, err = tt.n.ReadMetric(tt.queriedMetric)
 			if err == nil && tt.errorExpected {
+				t.Log(err)
 				t.Fail()
 			}
 		})

pkg/metrics/client_test.go

@@ -39,7 +39,7 @@ func dummyRestClientConfig() *restclient.Config {
 	fallbackReader := bytes.NewBuffer([]byte{})
 	clientConfig := clientcmd.NewInteractiveDeferredLoadingClientConfig(loadingRules, overrides, fallbackReader)
 	restConfig, err := clientConfig.ClientConfig()
-	if err == nil {
+	if err != nil {
 		log.Fatalf("Can't create dummy rest client config %v ", err)
 	}
 	return restConfig
@@ -98,7 +98,7 @@ func Test_customMetricsClient_GetNodeMetric(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			c := customMetricsClient{
+			c := CustomMetricsClient{
 				tt.fields.client,
 			}
 			got, err := c.GetNodeMetric(tt.args.metricName)
@@ -134,6 +134,7 @@ func TestNewClient(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			got := NewClient(tt.args.config)
 			if reflect.TypeOf(got) != reflect.TypeOf(dummyRestClientConfig()) {
+				log.Print("No real test implemented here")
 				//TODO:add some better verification constructor has worked here.
 			}
 		})

pkg/strategies/core/mocks.go

@@ -36,5 +36,5 @@ func (v *MockStrategy) GetPolicyName() string {
 
 //SetPolicyName sets the policy name of the mock strategy
 func (v *MockStrategy) SetPolicyName( policyName string)  {
-	return
+
 }

pkg/strategies/core/operator_test.go

@@ -53,10 +53,10 @@ func TestOrderedList(t *testing.T) {
 	tests := []struct {
 		name string
 		args args
-		want []nodeSortableMetric
+		want []NodeSortableMetric
 	}{
-		{"less than test", args{testNodeMetricCustomInfo([]string{"node A", "node B", "node C"}, []int64{100, 200, 10}), "LessThan"}, []nodeSortableMetric{{"node C", *resource.NewQuantity(10, resource.DecimalSI)}, {"node A", *resource.NewQuantity(100, resource.DecimalSI)}, {"node B", *resource.NewQuantity(200, resource.DecimalSI)}}},
-		{"greater than test", args{testNodeMetricCustomInfo([]string{"node A", "node B", "node C"}, []int64{100, 200, 10}), "GreaterThan"}, []nodeSortableMetric{{"node B", *resource.NewQuantity(200, resource.DecimalSI)}, {"node A", *resource.NewQuantity(100, resource.DecimalSI)}, {"node C", *resource.NewQuantity(10, resource.DecimalSI)}}},
+		{"less than test", args{testNodeMetricCustomInfo([]string{"node A", "node B", "node C"}, []int64{100, 200, 10}), "LessThan"}, []NodeSortableMetric{{"node C", *resource.NewQuantity(10, resource.DecimalSI)}, {"node A", *resource.NewQuantity(100, resource.DecimalSI)}, {"node B", *resource.NewQuantity(200, resource.DecimalSI)}}},
+		{"greater than test", args{testNodeMetricCustomInfo([]string{"node A", "node B", "node C"}, []int64{100, 200, 10}), "GreaterThan"}, []NodeSortableMetric{{"node B", *resource.NewQuantity(200, resource.DecimalSI)}, {"node A", *resource.NewQuantity(100, resource.DecimalSI)}, {"node C", *resource.NewQuantity(10, resource.DecimalSI)}}},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

pkg/strategies/deschedule/strategy.go

@@ -28,7 +28,6 @@ func (d *Strategy) StrategyType() string {
 //Returns a map of nodeNames as key with an empty value associated with each.
 func (d *Strategy) Violated(cache cache.Reader) map[string]interface{} {
 	violatingNodes := map[string]interface{}{}
-	output := []string{}
 	for _, rule := range d.Rules {
 		nodeMetrics, err := cache.ReadMetric(rule.Metricname)
 		if err != nil {
@@ -43,9 +42,6 @@ func (d *Strategy) Violated(cache cache.Reader) map[string]interface{} {
 			}
 		}
 	}
-	for k := range violatingNodes {
-		output = append(output, k)
-	}
 	return violatingNodes
 }
 

pkg/telemetrypolicy/api/v1alpha1/zz_generated_deepcopy.go

@@ -11,7 +11,7 @@ func (in *TASPolicy) DeepCopyInto(out *TASPolicy) {
 	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	out.Spec = in.Spec
 	out.Status = in.Status
-	return
+
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new TASPolicy.
@@ -44,7 +44,7 @@ func (in *TASPolicyList) DeepCopyInto(out *TASPolicyList) {
 			(*in)[i].DeepCopyInto(&(*out)[i])
 		}
 	}
-	return
+
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new TASPolicyList.
@@ -68,7 +68,6 @@ func (in *TASPolicyList) DeepCopyObject() runtime.Object {
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *TASPolicySpec) DeepCopyInto(out *TASPolicySpec) {
 	*out = *in
-	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new TASPolicySpec.
@@ -84,7 +83,6 @@ func (in *TASPolicySpec) DeepCopy() *TASPolicySpec {
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *TASPolicyStatus) DeepCopyInto(out *TASPolicyStatus) {
 	*out = *in
-	return
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new TASPolicyStatus.