This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[Outline View] Added node have event handler information. #290
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We'd better have an icon to indicate there are event handlers in the widget and clicking it will bring up the event handler dialog |
Contributor
Author
|
The code updated by your comments, please review. @zhizhangchen |
Contributor
|
I think the icon is too big and the lightening should have two branches instead of three. |
Contributor
|
"Using an icon to indicate existence of event handlers" should be a better commit message |
Contributor
There was a problem hiding this comment.
Using setTimeout is not reliable and should be avoid if possible. A better solution might be to extract the event handler code to a function in eventHandler.js so that both property view and outline view can call it.
Contributor
Author
|
Instead by #296. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue: https://01.org/jira/browse/RIB-35