Support for custom labels/descriptions in the Sensor model.Closes #1060#1086
Open
R1sh0bh-1 wants to merge 1 commit intointelowlproject:developfrom
Open
Support for custom labels/descriptions in the Sensor model.Closes #1060#1086R1sh0bh-1 wants to merge 1 commit intointelowlproject:developfrom
R1sh0bh-1 wants to merge 1 commit intointelowlproject:developfrom
Conversation
regulartim
requested changes
Mar 25, 2026
Collaborator
regulartim
left a comment
regulartim
left a comment
There was a problem hiding this comment.
Hey @R1sh0bh-1 ! Looks good all in all! Please, in addition to my comments, resolve the merge conflicts.
| raise serializers.ValidationError("Observable is not a valid IP address or domain") | ||
|
|
||
| try: | ||
| required_object = IOC.objects.prefetch_related("tags").get(name=observable) |
Collaborator
There was a problem hiding this comment.
I think we should add "sensors" to the prefetch_related() call.
Collaborator
There was a problem hiding this comment.
Could you please provide a screenshot of the frontend changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for custom labels/descriptions in the Sensor model, allowing users to better identify and distinguish sensors (e.g., "Home Office Pi" vs "Cloud AWS-EU") when running multiple honeypots.
Related issues
Closes #1060
Type of change
Checklist
Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.
Formalities
<feature name>. Closes #999develop.develop.Docs and tests
Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.GUI changes
Changes
Backend (Django)
labelfield (CharField, max 128 chars) to the Sensor model (blank=True,default="") to avoid breaking the existing extraction pipeline.SensorsModelAdminto include the label in the list view, allow inline editing, and support searching by label.SensorSerializerand integrated it intoIOCSerializer, so thesensorsfield now returns structured objects with addresses and labels.Frontend (React)
Tests & Quality
TableColumnsandEnrichmentLookupto ensure correct rendering of new fields.tests/__init__.pywhere datetime objects were being passed to DateField.Verification
Everything has been tested end-to-end sensors auto-create correctly, labels are manageable in the admin, the API returns the expected nested data, and the UI displays everything consistently.
@regulartim, please let me know if everything looks correct or if there’s anything I should improve.