Upgrade vendored llama.cpp to b10068 and bump to 0.11.0 - #24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust bindings to align with upstream llama.cpp b10068 changes and bumps the workspace release version to 0.11.0.
Changes:
- Passes
text_lenthrough the mtmd tokenizer input struct to match the updated upstream ABI. - Extends
KvCacheTypeto cover newly-added upstreamggml_typevariants and adds a completeness test to prevent silentUnknownfallbacks. - Updates integration test expectations and bumps workspace/crate versions to
0.11.0.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| llama-cpp-bindings/src/mtmd/mtmd_context.rs | Adds text_len when building mtmd_input_text for tokenization. |
| llama-cpp-bindings/src/model/params.rs | Adds a regression test guarding the fixed device array capacity vs upstream llama_max_devices(). |
| llama-cpp-bindings/src/context/kv_cache_type.rs | Adds new KvCacheType variants + a test ensuring upstream ggml_type coverage. |
| llama-cpp-bindings-tests/tests/multimodal_image_and_audio.rs | Updates expected vision output token (“alpaca”) for the combined image+audio test. |
| llama-cpp-bindings-sys/Cargo.toml | Adjusts crate packaging include list for vendored llama.cpp sources. |
| Cargo.toml | Bumps workspace and internal crate versions to 0.11.0. |
| Cargo.lock | Updates locked versions for workspace crates to 0.11.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored llama.cpp to b10068 and releases 0.11.0.