Sj/intorg 465#297
Draft
JoblersTune wants to merge 10 commits into
Draft
Conversation
✅ Deploy Preview for interledger-org-v5 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
acaff6b to
c8fb9be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blogs can be filtered by language and tags and should be able to switch between
ESandENstates while keeping consistent states and pagination.On
ENpage/blog/blogtheENlanguage content filter should be set and theAlltag should be set and no disclaimers are shownnext,previous,firstandlastbuttons)ESlanguage content filter two disclaimers should be shown (blog.lang_filter.viewing_es_postsandblog.lang_filter.more_en_available)ENfilter then no disclaimers should be shownnext,previous,firstandlastbuttons)next,previous,firstandlastbuttons)EN)All)On
ESpage/es/blog/es/blogtheESlanguage content filter should be set and theAlltag should be set and a disclaimer should show (blog.lang_filter.more_en_available)next,previous,firstandlastbuttons)ENfilter then one disclaimer should show (blog.lang_filter.viewing_en_posts)ESthen one disclaimer should show (blog.lang_filter.more_en_available).next,previous,firstandlastbuttons)next,previous,firstandlastbuttons)ES)All)Navigating from
ENtoESusing the global language switcher/blogand switch to/es/blogthen theESlanguage content filter should be set and theAlltag should be set and a disclaimer should show (blog.lang_filter.more_en_available)/blogand you select theESlanguage filter and then use the global language switcher to navigate to/es/blogtheESlanguage filter should stay on and a disclaimer should show (blog.lang_filter.more_en_available)/blogand you select a tag filter and then use the global language switcher to navigate to/es/blogtheESlanguage filter should be applied and the tag should be applied and a disclaimer should be present (blog.lang_filter.more_en_available)/blog/tag/announcements/lang/es/2,/blog/5, etc. For any language or tag filter combination and you switch to theESsite using the global langauge switcher then pagination should always return to the first page.Navigating from ES to EN using the global language switcher
/es/blogand switch to/blogthen theENlanguage content filter should be set and theAlltag should be set and no disclaimers should show/es/blogand you select theENlanguage filter and then use the global language switcher to navigate to/blogtheENlanguage filter should stay on and no disclaimers should be shown/es/blogand you select a tag filter and then use the global language switcher to navigate to/blogtheENlanguage filter should be set on and the tag should be applied and no disclaimers should be applied/es/blog/tag/announcements/lang/en/3,/es/blog/2, etc. For any language or tag filter combination and you switch to theENsite using the global langauge switcher then pagination should always return to the first page.Tag Availability & Empty State
All tags are available when the
ENlanguage filter is active. Only a subset of tags are available when theESlanguage filter is active. Unavailable tags are greyed out but still visible.Edge case — tag becomes unavailable after switching to
ES: if a user has anEN-only tag selected and then switches to theESlanguage filter (via the content filter or the global switcher), no posts will match. In this state:Show
blog.empty_tag_lang.messageandblog.lang_filter.more_en_availableBelow those disclaimers, display all
ESposts (ignoring the now-invalid tag filter) rather than showing an empty list. But keep the tag as part of the URL path since if the person switches to theENsite then their tag settings will still be respected.Related Issue
Fixes INTORG-465
Manual Test
See all required behaviour in the description
Checks
pnpm run formatpnpm run lintPR Checklist
feat: ...,fix: ...)