refactor(app): unify modal management #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment results
Logs #20744114670 |
5 tasks
sidvishnoi
requested changes
Dec 23, 2025
sidvishnoi
reviewed
Dec 30, 2025
sidvishnoi
reviewed
Dec 30, 2025
sidvishnoi
reviewed
Dec 31, 2025
frontend/app/components/redesign/components/ScriptReadyModal.tsx
Outdated
Show resolved
Hide resolved
sidvishnoi
reviewed
Dec 31, 2025
sidvishnoi
reviewed
Dec 31, 2025
| ) | ||
| } | ||
|
|
||
| export const useSaveResultModal = () => { |
Member
There was a problem hiding this comment.
This feels like it shouldn't belong to this file.
sidvishnoi
reviewed
Dec 31, 2025
Member
sidvishnoi
left a comment
sidvishnoi
left a comment
There was a problem hiding this comment.
I presently can't save config from banner-two route, but the modals work well.
Member
Author
will take care of this further next by creating a new save one-profile-at-a-time route API that uses the new profile type. |
sidvishnoi
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #479
Requested Changes
Reduce boilerplate, enforces consistent modal pattern and improves maintainability by centralizing modal control
DialogProviderusing react contextwidget,bannerandbanner-twoof modalsCustom hooks for modal logic:
useSaveResultModal- encapsulates save resultuseGrantResponseHandler- appropriate success/error modals after grant response flow after wallet ownership verificationNote to reviewer: the internal logic and state of individual modal types remain unchanged; only the orchestration and rendering approach has been unified.