Hide sort menu for series lists#12060
Merged
cdrini merged 1 commit intointernetarchive:masterfrom Mar 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hides the “Sort by” dropdown on Series pages to avoid presenting sorting controls that don’t currently work for the /series/ namespace, while keeping the layout toggle available.
Changes:
- Wraps the
search/sort_options.htmlrender in a conditional so it doesn’t display forlist.keyunder/series/. - Leaves
search/layout_options.htmlrendering unchanged so Grid/List layout remains available on Series.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12054
fix: Hides the sorting dropdown menu on Series pages.
As discussed on Slack, the sorting logic is currently designed for standard Lists and does not yet support the new Series data structure. This PR hides the UI element on Series pages to prevent user confusion during the beta rollout.
Technical
openlibrary/templates/lists/view_body.htmlsearch/sort_options.htmltemplate render call in a conditional block ($if not list.key.startswith('/series/'):).list.keynamespace at the parent level (view_body), we successfully hide the dropdown for Series without having to alter the sharedsort_options.htmlwidget itself. The layout toggle (Grid/List view) is intentionally left outside the condition so it remains functional.Testing
Screenshot
Series example:


List example:
Stakeholders
cc @cdrini - Thanks for pointing me toward this as a good first issue!