Feat/unify sync status in a context manager#274
Merged
Conversation
AlexisMora
reviewed
Mar 23, 2026
AlexisMora
left a comment
AlexisMora
left a comment
There was a problem hiding this comment.
Also, check the sonarcloud issues
|
|
||
| const SyncContext = createContext<SyncContextValue>({ syncStatus: 'STANDBY' }); | ||
|
|
||
| export function SyncProvider({ children }: { children: ReactNode }) { |
There was a problem hiding this comment.
Suggested change
| export function SyncProvider({ children }: { children: ReactNode }) { | |
| export function SyncProvider({ children }: { readonly children: ReactNode }) { |
|
|
||
| function onSyncStatusChanged(value: SyncStatus) { | ||
| if (value === 'RUNNING') { | ||
| useEffect(() => { |
There was a problem hiding this comment.
Why not use useOnSyncRunning?
I would either scrap the useOnSyncRunning if you are not going to use it, because as far as we can see, its a super thin wrapper inside a useEffect
|
AlexisMora
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
Synchronization state management has been consolidated into a context manager to improve communication among all the components involved.
A new button has been added to manually start the sync process