Open
Conversation
AlexisMora
changed the title
|
AlexisMora
commented
Mar 18, 2026
| @@ -0,0 +1,44 @@ | |||
| import { logger } from '@internxt/drive-desktop-core/build/backend'; | |||
Author
There was a problem hiding this comment.
the behaviour of this handler is the same as the previous code inside ReleaseCallback, the only difference is that gives more context about what is really happening and providing better naming (For example const temporalFile = await findTemporalFile(path); instead of const document = await this.findDocument(path); at a first glance it is more explicit about the intention
egalvis27
requested changes
Mar 18, 2026
src/backend/features/fuse/on-release/handle-release-callback.test.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
Extracted the find and upload temporal file logic from
ReleaseCallbackinto a dedicatedhandler. Added JSDoc on
TemporalFileand onReleaseCallbackto document the overall logicExtracted the
TEMPORAL_FOLDERINTERNXT_DRIVE_TMPto the dedicated Paths objectWhy
The original callback was doing too much with no named concepts, making it hard to follow when reading it. The JSDocs provides better context and the why behind the logic