Merged
Conversation
egalvis27
commented
Mar 19, 2026
| }, | ||
| onUpdateAvailable(callback) { | ||
| const eventName = 'update-available'; | ||
| const callbackWrapper = (_, info) => callback(info); |
Author
There was a problem hiding this comment.
This handler is used to check at runtime whether a new version is available for updating.
AlexisMora
reviewed
Mar 23, 2026
| import { createAuthWindow, getAuthWindow } from './windows/auth'; | ||
| import configStore from './config'; | ||
| import { getTray, setTrayStatus } from './tray/tray'; | ||
| import { broadcastToWindows } from './windows'; |
There was a problem hiding this comment.
'./windows' imported multiple times.
src/apps/main/main.ts
Outdated
Comment on lines
+87
to
+98
| let pendingUpdateInfo: { version: string } | null = null; | ||
|
|
||
| async function checkForUpdates() { | ||
| if (!process.env.APPIMAGE) { | ||
| const updateInfo = await checkForUpdatesOnDeb({ currentVersion: INTERNXT_VERSION }); | ||
| if (updateInfo) { | ||
| pendingUpdateInfo = updateInfo; | ||
| broadcastToWindows('update-available', updateInfo); | ||
| } | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
This could go in its own file instead of main.ts, perhaps inside src/core? Dont forget to add tests
| @@ -0,0 +1,50 @@ | |||
| import https from 'https'; | |||
There was a problem hiding this comment.
Prefer node:https over https.
Check sonarcloud issues
AlexisMora
approved these changes
Mar 24, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
An option to receive update notifications in the app has been added when the user installs the .deb version