[PB-5727]: upload concurrently with worker pool to improve speed#283
Open
AlexisMora wants to merge 9 commits intomainfrom
Open
[PB-5727]: upload concurrently with worker pool to improve speed#283AlexisMora wants to merge 9 commits intomainfrom
AlexisMora wants to merge 9 commits intomainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What is Changed / Added
now, create and update flows now run 10 uploads concurrently via async.queue,
also.introduced executeAsyncQueue(items, executor, config) as a generic wrapper. Both createBackupUploadExecutor and createBackupUpdateExecutor implement the same TaskExecutor interface and plug directly into it.
uploads now retry up to 3 times with [1s, 2s, 4s] exponential backoff before giving up on a file
The logic per file is identical to the old implementation:
Upload bytes to bucket -> get contentsId
Create/override metadata in backend
On metadata failure -> clean up uploaded content (create only; update matches old behavior of not cleaning up)
FILE_ALREADY_EXISTS -> skip silently
Non-fatal errors ->tracked in backupErrorsTracker
Fatal errors -> stop all uploads immediately
The only intentional behavior changes are: concurrency (10 parallel instead of 1) and retry (3 attempts with backoff instead of 0).