[_]: fetch fresh email verification status and update referral reward amount#1894
Open
[_]: fetch fresh email verification status and update referral reward amount#1894
Conversation
…d amount - Fetch emailVerified from API in openPanel to avoid stale local state - Close Cello panel when email is not verified to prevent modal overlap - Remove cello-launcher attribute from AccountPopover to avoid SDK auto-open - Fix Cello notification dot causing layout shift via CSS absolute positioning - Update referral reward amount from €1,000 to €100 across all locales
terrerox
changed the title
Deploying drive-web with
|
| Latest commit: |
6a289d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://417228e2.drive-web.pages.dev |
| Branch Preview URL: | https://feature-cello-email-blocker.drive-web.pages.dev |
CandelR
requested changes
Mar 25, 2026
Comment on lines
+68
to
+76
| const fetchEmailVerifiedStatus = async (fallback: boolean): Promise<boolean> => { | ||
| try { | ||
| const usersClient = SdkFactory.getNewApiInstance().createUsersClient(); | ||
| const { user } = await usersClient.refreshUser(); | ||
| return user.emailVerified; | ||
| } catch { | ||
| return fallback; | ||
| } | ||
| }; |
Collaborator
There was a problem hiding this comment.
I think taht it is not necessary to do the fetch if user.emailVerified is already true
src/services/referral.service.ts
Outdated
Comment on lines
+139
to
+144
| text: 'Verify your email to be elegible to referrals. Check your inbox or', | ||
| type: ToastType.Info, | ||
| duration: Infinity, | ||
| containerClassName: 'w-100 border-primary/30 bg-primary/5 dark:bg-primary/10', | ||
| action: { | ||
| text: 'resend verification', |
Collaborator
There was a problem hiding this comment.
Rembember to add the text to translations file :)
| }, | ||
| }); | ||
| if (globalThis.Cello) { | ||
| await globalThis.Cello('close'); |
Collaborator
There was a problem hiding this comment.
Is this a call to the Cello API? It might be a good idea to encapsulate it so that it doesn’t look so odd and is easier to maintain (in another task)
…ication check - replace hardcoded referral verification toast text with i18n keys - add email verification message/action translations to all supported locales - skip API verification lookup when user is already marked as verified - remove explicit infinite toast duration to use default notification behavior
|
CandelR
reviewed
Mar 25, 2026
Comment on lines
+1651
to
+1653
| "emailVerification": { | ||
| "message": "Verifica tu correo electrónico para ser elegible para referidos. Revisa tu bandeja de entrada o", | ||
| "resendVerification": "reenviar verificación" |
Collaborator
There was a problem hiding this comment.
I think something’s missing here "Revisa tu bandeja de entrada o" or what? :O
It might work in English, but in other languages it sounds a bit robotic, like in Spanish
Contributor
Author
There was a problem hiding this comment.
That is aligned with the design provided by the product team
CandelR
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes