Conversation
xabg2
reviewed
Mar 23, 2026
src/mail/index.ts
Outdated
| */ | ||
| async sendEncryptedEmail(email: HybridEncryptedEmail): Promise<void> { | ||
| return this.client.post(`${this.apiUrl}/emails`, { emails: [email] }, this.headers()); | ||
| async sendEncryptedEmail(email: HybridEncryptedEmail, params: EmailPublicParameters): Promise<void> { |
Contributor
There was a problem hiding this comment.
Consider handling CC and BCC recipients inside EmailPublicParameters.
Also, we can unify recipient/recipients into recipients: User[] only.
TamaraFinogina
changed the title
xabg2
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Mail API after breaking changes in internxt-crypto 1.0.2
breaking change = switch to hybrid keys and email encryption doesn't require email parameters anymore