Draft
Conversation
src/mail/api.ts
Outdated
| return this.client.post(`${this.apiUrl}/emails`, { email, params }, this.headers()); | ||
| } | ||
|
|
||
| async getE2EEmails(): Promise<Email[]> { |
Contributor
There was a problem hiding this comment.
Email? Shouldn't it be HybridEncryptedEmail? and different methods like for send
Contributor
Author
There was a problem hiding this comment.
This function goes out. The types are the types the Mail API are returning. We can add the encryptedKey, but the types from crypto are not valid.
| return this.client.delete(`${this.apiUrl}/email/${id}`, this.headers()); | ||
| } | ||
|
|
||
| async updateEmail(id: string, body: UpdateEmailRequest): Promise<void> { |
Contributor
Author
There was a problem hiding this comment.
This EP will be used to mark an email as read/flagged.
| } | ||
|
|
||
| async saveDraft(body: DraftEmailRequest): Promise<EmailCreatedResponse> { | ||
| return this.api.saveDraft(body); |
Contributor
There was a problem hiding this comment.
Should we encrypt it first? With a user mnemonic, for example, just for storing on the server?
Contributor
Author
There was a problem hiding this comment.
Yes, I think we should encrypt the messages here.
yarn.lock
Outdated
| @@ -13,12 +13,12 @@ | |||
|
|
|||
| "@babel/compat-data@^7.28.6": | |||
| version "7.29.0" | |||
| resolved "https://registry.yarnpkg.com/@babel/compat-data/-/compat-data-7.29.0.tgz#00d03e8c0ac24dd9be942c5370990cbe1f17d88d" | |||
| resolved "https://registry.npmjs.org/@babel/compat-data/-/compat-data-7.29.0.tgz" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Mail's basic EPs, which are already available in our Mail API.