Reverse changes if item is removed#179
Open
the-bird-is-the-word wants to merge 1 commit intoinveniosoftware:masterfrom
Open
Reverse changes if item is removed#179the-bird-is-the-word wants to merge 1 commit intoinveniosoftware:masterfrom
the-bird-is-the-word wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
Member
That would be awesome! And thank you for spotting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #178, I think in function
swapneeds to be modified. If a swap is performed on aremoveaction, the list of changes needs to be reversed. Just like it is done in case of anaddaction.What do you think?
I can also add some tests if you want. (I noticed that there are no tests on the revert or swap methods until now)