diff: allow tolerance only between floats#183
Open
dbrakman wants to merge 1 commit intoinveniosoftware:masterfrom
Open
diff: allow tolerance only between floats#183dbrakman wants to merge 1 commit intoinveniosoftware:masterfrom
dbrakman wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
* Enable and require absolute equality between large integers not possible with math.isclose * Replace num_types usage with consistent behavior among subclasses of numbers.Number
Contributor
|
Instead of this change, why don't we set the default tolerance to 1e-int_Max? |
Author
|
There is no int_Max: https://docs.python.org/3/whatsnew/3.0.html#integers Applying any tolerance for integers would impose a guess as to what magnitudes of numbers people are likely to use or what range of values one's test suite can accept. The tolerance parameter's stated goal of allowing floating point imprecision isn't applicable to integers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For #181
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: