components: remove defaultProps from components

src/demos/App.js

@@ -24,13 +24,9 @@
 };
 
 CurrentRecord.propTypes = {
   record: PropTypes.object,
 };
 
-CurrentRecord.defaultProps = {
-  record: undefined,
-};
-
 class RecordPreviewer extends Component {
   render() {
     const { record } = this.props;
@@ -39,13 +35,9 @@
 }
 
 RecordPreviewer.propTypes = {
   record: PropTypes.object,
 };
 
-RecordPreviewer.defaultProps = {
-  record: undefined,
-};
-
 class App extends Component {
   constructor(props) {
     super(props);

src/lib/elements/ErrorMessage.js

@@ -69,7 +69,7 @@
   /**
    * The list of errors (In case of multiple errors. ex: form validation result).
    */
   errors: PropTypes.arrayOf(
     PropTypes.shape({
       field: PropTypes.string,
       messages: PropTypes.arrayOf(PropTypes.string.isRequired).isRequired,
@@ -78,19 +78,11 @@
   /**
    * Custom error header.
    */
   header: PropTypes.string,
   uiProps: PropTypes.object,
   /**
    * Single error message (ex: http error response message).
    */
   content: PropTypes.string,
   icon: PropTypes.string,
 };
-
-ErrorMessage.defaultProps = {
-  errors: undefined,
-  header: undefined,
-  uiProps: undefined,
-  icon: undefined,
-  content: undefined,
-};

src/lib/elements/GridResponsiveSidebarColumn.js

@@ -68,24 +68,14 @@
 }
 
 GridResponsiveSidebarColumn.propTypes = {
   width: PropTypes.number,
   open: PropTypes.bool.isRequired,
   onHideClick: PropTypes.func.isRequired,
   children: PropTypes.any.isRequired,
   mobile: PropTypes.number,
   tablet: PropTypes.number,
   computer: PropTypes.number,
   largeScreen: PropTypes.number,
   widescreen: PropTypes.number,
   ariaLabel: PropTypes.string,
 };
-
-GridResponsiveSidebarColumn.defaultProps = {
-  width: undefined,
-  mobile: undefined,
-  tablet: undefined,
-  computer: undefined,
-  widescreen: undefined,
-  largeScreen: undefined,
-  ariaLabel: undefined,
-};

src/lib/elements/Image.js

@@ -15,7 +15,11 @@ import axios from "axios";
  */
 export class Image extends Component {
   async componentDidMount() {
-    const { fallbackSrc, loadFallbackFirst, src } = this.props;
+    const {
+      fallbackSrc = "/static/images/square-placeholder.png",
+      loadFallbackFirst = false,
+      src,
+    } = this.props;
     if (loadFallbackFirst) {
       try {
         await axios.get(src);
@@ -51,8 +55,14 @@ export class Image extends Component {
   };
 
   render() {
-    const { alt, className, src, fallbackSrc, loadFallbackFirst, ...UIprops } =
-      this.props;
+    const {
+      alt = "No image found",
+      className = "",
+      src,
+      fallbackSrc = "/static/images/square-placeholder.png",
+      loadFallbackFirst = false,
+      ...UIprops
+    } = this.props;
     const loadingClass = !loadFallbackFirst
       ? `${className} placeholder`
       : `${className} fallback_image`;
@@ -89,10 +99,3 @@ Image.propTypes = {
   alt: PropTypes.string,
   loadFallbackFirst: PropTypes.bool,
 };
-
-Image.defaultProps = {
-  className: "",
-  alt: "No image found",
-  fallbackSrc: "/static/images/square-placeholder.png",
-  loadFallbackFirst: false,
-};

src/lib/elements/accessibility/InvenioPopup.js

@@ -12,13 +12,13 @@ export class InvenioPopup extends Component {
   render() {
     const {
       popupId,
-      size,
+      size = "small",
       trigger,
       content,
-      position,
-      inverted,
+      position = "top left",
+      inverted = false,
       ariaLabel,
-      hoverable,
+      hoverable = true,
     } = this.props;
 
     return (
@@ -54,10 +54,3 @@ InvenioPopup.propTypes = {
   position: PropTypes.string,
   size: PropTypes.string,
 };
-
-InvenioPopup.defaultProps = {
-  inverted: false,
-  position: "top left",
-  size: "small",
-  hoverable: true,
-};

src/lib/elements/bulk_actions/SearchResultsBulkActions.js

@@ -15,7 +15,7 @@ import _pickBy from "lodash/pickBy";
 export default class SearchResultsBulkActions extends Component {
   constructor(props) {
     super(props);
-    const { allSelected } = this.props;
+    const { allSelected = false } = this.props;
     this.state = { allSelectedChecked: allSelected };
   }
 
@@ -86,7 +86,3 @@ SearchResultsBulkActions.propTypes = {
   allSelected: PropTypes.bool,
   optionSelectionCallback: PropTypes.func.isRequired,
 };
-
-SearchResultsBulkActions.defaultProps = {
-  allSelected: false,
-};

src/lib/elements/contrib/invenioRDM/users/UserListItemCompact.js

@@ -40,7 +40,3 @@ UserListItemCompact.propTypes = {
   id: PropTypes.string.isRequired,
   linkToDetailView: PropTypes.string,
 };
-
-UserListItemCompact.defaultProps = {
-  linkToDetailView: undefined,
-};

src/lib/forms/AccordionField.js

@@ -106,7 +106,7 @@ class AccordionError extends Component {
 
   render() {
     const { errors } = this.state;
-    const { severityChecks } = this.props;
+    const { severityChecks = null } = this.props;
     if (errors === undefined) {
       return null;
     }
@@ -133,14 +133,10 @@ AccordionError.propTypes = {
   severityChecks: PropTypes.object,
 };
 
-AccordionError.defaultProps = {
-  severityChecks: null,
-};
-
 export class AccordionField extends Component {
   constructor(props) {
     super(props);
-    const { active } = this.props;
+    const { active = true } = this.props;
     this.state = { hasError: false, activeIndex: active ? 0 : -1 };
   }
 
@@ -155,7 +151,12 @@ export class AccordionField extends Component {
   };
 
   renderAccordion = (props) => {
-    const { label, children, includesPaths, severityChecks } = this.props;
+    const {
+      label = "",
+      children = null,
+      includesPaths = [],
+      severityChecks = null,
+    } = this.props;
     const { hasError, activeIndex } = this.state;
     // Omit props, so they don't get spread into Accordion https://react.semantic-ui.com/modules/accordion/#types-standard
     const uiProps = _omit(this.props, [
@@ -207,7 +208,7 @@ export class AccordionField extends Component {
   };
 
   render() {
-    const { optimized } = this.props;
+    const { optimized = false } = this.props;
     const FormikField = optimized ? FastField : Field;
     return <FormikField name="" component={this.renderAccordion} />;
   }
@@ -222,13 +223,3 @@ AccordionField.propTypes = {
   ui: PropTypes.object,
   severityChecks: PropTypes.object,
 };
-
-AccordionField.defaultProps = {
-  active: true,
-  includesPaths: [],
-  label: "",
-  optimized: false,
-  children: null,
-  ui: null,
-  severityChecks: null,
-};

src/lib/forms/ArrayField.js

@@ -73,16 +73,16 @@ export class ArrayField extends Component {
       ...arrayHelpers
     } = props;
     const {
-      addButtonLabel,
-      addButtonClassName,
+      addButtonLabel = "Add new row",
+      addButtonClassName = "align-self-end mt-15",
       children,
       defaultNewValue,
       fieldPath,
-      label,
-      labelIcon,
-      helpText,
-      requiredOptions,
-      showEmptyValue,
+      label = "",
+      labelIcon = "",
+      helpText = "",
+      requiredOptions = [],
+      showEmptyValue = false,
       ...uiProps
     } = this.props;
     const hasError = this.hasGroupErrors(errors) ? { error: {} } : {};
@@ -160,13 +160,3 @@ ArrayField.propTypes = {
   requiredOptions: PropTypes.array,
   showEmptyValue: PropTypes.bool,
 };
-
-ArrayField.defaultProps = {
-  addButtonLabel: "Add new row",
-  addButtonClassName: "align-self-end mt-15",
-  helpText: "",
-  label: "",
-  labelIcon: "",
-  requiredOptions: [],
-  showEmptyValue: false,
-};

src/lib/forms/BaseForm/BaseForm.js

@@ -30,7 +30,3 @@ BaseForm.propTypes = {
     validate: PropTypes.func,
   }),
 };
-
-BaseForm.defaultProps = {
-  formik: undefined,
-};

src/lib/forms/BooleanField.js

@@ -22,7 +22,7 @@ export class BooleanField extends Component {
   }
 
   renderFormField = (props) => {
-    const { fieldPath, label, ...uiProps } = this.props;
+    const { fieldPath, label = "", ...uiProps } = this.props;
     const {
       form: { values, handleBlur, errors, initialErrors, initialValues, setFieldValue },
     } = props;
@@ -47,7 +47,7 @@ export class BooleanField extends Component {
     );
   };
   render() {
-    const { optimized, fieldPath } = this.props;
+    const { optimized = false, fieldPath } = this.props;
     const FormikField = optimized ? FastField : Field;
     return (
       <FormikField
@@ -64,8 +64,3 @@ BooleanField.propTypes = {
   label: PropTypes.string,
   optimized: PropTypes.bool,
 };
-
-BooleanField.defaultProps = {
-  label: "",
-  optimized: false,
-};

src/lib/forms/FeedbackLabel.js

@@ -30,7 +30,7 @@ export class FeedbackLabel extends Component {
   };
 
   computeErrors = (errors, initialErrors) => {
-    const { fieldPath, injectedError, hasSubfields } = this.props;
+    const { fieldPath, injectedError, hasSubfields = false } = this.props;
     let error;
 
     if (injectedError) {
@@ -64,7 +64,7 @@ export class FeedbackLabel extends Component {
   };
 
   renderErrors = ({ form: { errors, initialErrors } }) => {
-    const { fieldPath, pointing } = this.props;
+    const { fieldPath, pointing = "left" } = this.props;
     const { error, errMessage, hasSeverity } = this.computeErrors(
       errors,
       initialErrors
@@ -111,10 +111,3 @@ FeedbackLabel.propTypes = {
   fieldPath: PropTypes.string,
   hasSubfields: PropTypes.bool,
 };
-
-FeedbackLabel.defaultProps = {
-  injectedError: undefined,
-  pointing: "left",
-  fieldPath: undefined,
-  hasSubfields: false,
-};

src/lib/forms/FieldLabel.js

@@ -12,7 +12,12 @@ import { Icon } from "semantic-ui-react";
 
 export class FieldLabel extends Component {
   render() {
-    const { htmlFor, icon, label, className } = this.props;
+    const {
+      htmlFor,
+      icon = "",
+      label,
+      className = "field-label-class invenio-field-label",
+    } = this.props;
     return (
       <label htmlFor={htmlFor} className={className}>
         {icon ? <Icon name={icon} /> : null}
@@ -28,10 +33,3 @@ FieldLabel.propTypes = {
   icon: PropTypes.string,
   className: PropTypes.string,
 };
-
-FieldLabel.defaultProps = {
-  className: "field-label-class invenio-field-label",
-  icon: "",
-  htmlFor: undefined,
-  label: undefined,
-};

src/lib/forms/FilesList.js

@@ -49,8 +49,3 @@ FilesList.propTypes = {
   files: PropTypes.array,
   onFileDelete: PropTypes.func,
 };
-
-FilesList.defaultProps = {
-  files: undefined,
-  onFileDelete: undefined,
-};

src/lib/forms/GroupField.js

@@ -31,7 +31,14 @@ export class GroupField extends React.Component {
   };
 
   renderFormField = (props) => {
-    const { action, basic, border, children, fieldPath, ...uiProps } = props;
+    const {
+      action,
+      basic = false,
+      border = false,
+      children,
+      fieldPath = "",
+      ...uiProps
+    } = props;
     const errors = getIn(props, "form.errors");
     const classNames = ["form-group"];
     if (border) {
@@ -54,7 +61,7 @@ export class GroupField extends React.Component {
   };
 
   render() {
-    const { optimized, fieldPath, ...uiProps } = this.props;
+    const { optimized = false, fieldPath = "", ...uiProps } = this.props;
 
     const FormikField = optimized ? FastField : Field;
     return (
@@ -77,12 +84,3 @@ GroupField.propTypes = {
   basic: PropTypes.bool,
   children: PropTypes.any,
 };
-
-GroupField.defaultProps = {
-  border: false,
-  fieldPath: "",
-  optimized: false,
-  action: undefined,
-  basic: false,
-  children: undefined,
-};